Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Fix NMODL_GENERATED_SOURCES without Python.#1553

Merged
1uc merged 2 commits into
masterfrom
1uc/fix-cmake-deps
Nov 6, 2024
Merged

Fix NMODL_GENERATED_SOURCES without Python.#1553
1uc merged 2 commits into
masterfrom
1uc/fix-cmake-deps

Conversation

@1uc

@1uc 1uc commented Nov 6, 2024

Copy link
Copy Markdown
Collaborator

The logs state that it's regenerating the sources because:

build-integrate/external/nmodl/src/pybind/pyast.cpp

is missing. Which makes sense, because we don't build the NMODL Python binding when it's integrated into NRN.

@1uc 1uc force-pushed the 1uc/fix-cmake-deps branch from 45e82a8 to f9b0f15 Compare November 6, 2024 09:50
@1uc 1uc marked this pull request as ready for review November 6, 2024 10:05

@alkino alkino left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whouhou

@1uc 1uc merged commit 0186d19 into master Nov 6, 2024
@1uc 1uc deleted the 1uc/fix-cmake-deps branch November 6, 2024 10:09
JCGoran pushed a commit to neuronsimulator/nrn that referenced this pull request Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants