Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Implement wrote_conc.#1334

Merged
1uc merged 8 commits into
masterfrom
1uc/wrote_conc
Jul 11, 2024
Merged

Implement wrote_conc.#1334
1uc merged 8 commits into
masterfrom
1uc/wrote_conc

Conversation

@1uc

@1uc 1uc commented Jul 9, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jul 9, 2024
@codecov

codecov Bot commented Jul 9, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 98.25328% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.14%. Comparing base (87e11cb) to head (26d0ac0).

Files Patch % Lines
src/codegen/codegen_coreneuron_cpp_visitor.cpp 78.57% 3 Missing ⚠️
src/codegen/codegen_cpp_visitor.cpp 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1334      +/-   ##
==========================================
+ Coverage   85.30%   86.14%   +0.83%     
==========================================
  Files         178      179       +1     
  Lines       13469    13663     +194     
==========================================
+ Hits        11490    11770     +280     
+ Misses       1979     1893      -86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

@1uc 1uc marked this pull request as ready for review July 10, 2024 07:18
Comment thread docs/contents/ions.rst Outdated
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jul 10, 2024
@bbpbuildbot

This comment has been minimized.

@pramodk pramodk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added one/two comments but this is LGTM!

Comment thread src/utils/string_utils.hpp Outdated
Comment thread src/codegen/codegen_neuron_cpp_visitor.cpp Outdated
Comment thread src/codegen/codegen_neuron_cpp_visitor.cpp
Comment thread docs/contents/ions.rst
and fiddle some doc strings.
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jul 10, 2024
@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

@1uc 1uc force-pushed the 1uc/wrote_conc branch from 5536d4c to 1619bf6 Compare July 11, 2024 09:26
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jul 11, 2024
@1uc 1uc force-pushed the 1uc/wrote_conc branch from 1619bf6 to 26d0ac0 Compare July 11, 2024 09:33
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jul 11, 2024
@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #221300 (:white_check_mark:) have been uploaded here!

Status and direct links:

@1uc 1uc merged commit 332c8b3 into master Jul 11, 2024
@1uc 1uc deleted the 1uc/wrote_conc branch July 11, 2024 11:22
JCGoran pushed a commit to neuronsimulator/nrn that referenced this pull request Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants