This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Fix thread variables with Newton code.#1332
Merged
Merged
Conversation
Solving non-linear system causes a function object to be present in the generated code. This function object was missing the required code to handle thread-variables.
a6f2fa4 to
8a80b0a
Compare
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jul 8, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1332 +/- ##
==========================================
- Coverage 85.37% 85.33% -0.05%
==========================================
Files 178 178
Lines 13459 13466 +7
==========================================
Hits 11491 11491
- Misses 1968 1975 +7 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Logfiles from GitLab pipeline #220796 (:white_check_mark:) have been uploaded here! Status and direct links: |
pramodk
approved these changes
Jul 8, 2024
JCGoran
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 12, 2025
Solving non-linear system causes a function object to be present in the generated code. This function object was missing the required code to handle thread-variables. NMODL Repo SHA: BlueBrain/nmodl@87e11cb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solving non-linear system causes a function object to be present in the generated code. This function object was missing the required code to handle thread-variables.