This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Fix (NON)LINEAR block with explicit SOLVEFOR#1326
Merged
Merged
Conversation
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jun 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1326 +/- ##
==========================================
- Coverage 85.37% 85.37% -0.01%
==========================================
Files 178 178
Lines 13440 13458 +18
==========================================
+ Hits 11475 11490 +15
- Misses 1965 1968 +3 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
1uc
reviewed
Jun 19, 2024
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jun 19, 2024
Contributor
Author
|
It seems that, according to the docs, you can also use SOLVEFOR in KINETIC, which I believe requires modifying some other visitor (which one?): |
Collaborator
|
Logfiles from GitLab pipeline #217825 (:no_entry:) have been uploaded here! Status and direct links: |
1uc
approved these changes
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The (NON)LINEAR block in NMODL was not accounting for the SOLVEFOR variables, which means that something like the following would fail (when used with
sympy --analytic):because the SOLVEFOR variables were not accounted for, only the STATE ones, which caused the solver to think this was a nonlinear system due to the presence of the
z * yterm in the second equation (i.e. the solver would try to solve the system for all STATE variables instead of just the ones specified in SOLVEFOR).