Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Implement diam and area.#1323

Merged
pramodk merged 3 commits into
masterfrom
1uc/morphology
Jul 8, 2024
Merged

Implement diam and area.#1323
pramodk merged 3 commits into
masterfrom
1uc/morphology

Conversation

@1uc

@1uc 1uc commented Jun 17, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

@1uc

1uc commented Jun 17, 2024

Copy link
Copy Markdown
Collaborator Author

The SEGFAULT is expected until we merge: neuronsimulator/nrn#2914

@codecov

codecov Bot commented Jun 17, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 85.35%. Comparing base (7910146) to head (660124f).

Files Patch % Lines
src/codegen/codegen_neuron_cpp_visitor.cpp 27.27% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1323      +/-   ##
==========================================
- Coverage   85.37%   85.35%   -0.03%     
==========================================
  Files         178      178              
  Lines       13459    13462       +3     
==========================================
- Hits        11491    11490       -1     
- Misses       1968     1972       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

@1uc 1uc closed this Jun 18, 2024
@1uc 1uc reopened this Jun 18, 2024
@bbpbuildbot

This comment has been minimized.

@1uc 1uc closed this Jun 18, 2024
@1uc 1uc reopened this Jun 18, 2024
@bbpbuildbot

This comment has been minimized.

@1uc 1uc force-pushed the 1uc/morphology branch from 53b23f4 to 7c64f7b Compare June 27, 2024 11:09
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jun 27, 2024
@bbpbuildbot

This comment has been minimized.

@1uc 1uc marked this pull request as ready for review June 27, 2024 16:00
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jul 8, 2024
@bbpbuildbot

This comment has been minimized.

Comment thread src/codegen/codegen_neuron_cpp_visitor.cpp
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jul 8, 2024

@pramodk pramodk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #220792 (:white_check_mark:) have been uploaded here!

Status and direct links:

@pramodk pramodk merged commit a209d0a into master Jul 8, 2024
@pramodk pramodk deleted the 1uc/morphology branch July 8, 2024 14:11
JCGoran pushed a commit to neuronsimulator/nrn that referenced this pull request Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants