Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Document global variables.#1321

Merged
pramodk merged 5 commits into
masterfrom
1uc/doc-globals
Jun 17, 2024
Merged

Document global variables.#1321
pramodk merged 5 commits into
masterfrom
1uc/doc-globals

Conversation

@1uc

@1uc 1uc commented Jun 13, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

@1uc 1uc marked this pull request as ready for review June 13, 2024 12:12
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jun 13, 2024
@codecov

codecov Bot commented Jun 13, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.37%. Comparing base (e9e127a) to head (dc0976f).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1321      +/-   ##
==========================================
+ Coverage   85.34%   85.37%   +0.02%     
==========================================
  Files         178      178              
  Lines       13412    13436      +24     
==========================================
+ Hits        11447    11471      +24     
  Misses       1965     1965              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jun 14, 2024
@bbpbuildbot

This comment has been minimized.

@pramodk pramodk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Very nicely written, Luc!

One clarification otherwise LGTM!

Comment thread docs/contents/globals.rst Outdated
Comment thread docs/contents/globals.rst Outdated
Comment thread docs/contents/globals.rst Outdated
Comment thread docs/contents/globals.rst Outdated
Comment thread docs/contents/globals.rst Outdated
Co-authored-by: Pramod Kumbhar <pramod.kumbhar@epfl.ch>
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jun 17, 2024
@bbpbuildbot

This comment has been minimized.

bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jun 17, 2024
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jun 17, 2024
@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #217175 (:white_check_mark:) have been uploaded here!

Status and direct links:

@pramodk pramodk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pramodk pramodk merged commit 5ff221d into master Jun 17, 2024
@pramodk pramodk deleted the 1uc/doc-globals branch June 17, 2024 12:15
JCGoran pushed a commit to neuronsimulator/nrn that referenced this pull request Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants