Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Implement top-level LOCAL variables.#1315

Merged
1uc merged 1 commit into
masterfrom
1uc/top-local
Jun 13, 2024
Merged

Implement top-level LOCAL variables.#1315
1uc merged 1 commit into
masterfrom
1uc/top-local

Conversation

@1uc

@1uc 1uc commented Jun 12, 2024

Copy link
Copy Markdown
Collaborator

These are global variables, and when THREAD_SAFE act like thread variables, without being exposed to HOC/Python.

These are global variables, and when THREAD_SAFE act like thread
variables, without being exposed to HOC/Python.
@1uc 1uc force-pushed the 1uc/top-local branch from 2b586f8 to 2fc0d77 Compare June 12, 2024 11:11
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jun 12, 2024
@codecov

codecov Bot commented Jun 12, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 85.39%. Comparing base (9562893) to head (2fc0d77).
Report is 3 commits behind head on master.

Files Patch % Lines
src/codegen/codegen_neuron_cpp_visitor.cpp 27.27% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1315      +/-   ##
==========================================
- Coverage   85.45%   85.39%   -0.07%     
==========================================
  Files         178      178              
  Lines       13382    13402      +20     
==========================================
+ Hits        11435    11444       +9     
- Misses       1947     1958      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #216514 (:white_check_mark:) have been uploaded here!

Status and direct links:

@1uc 1uc marked this pull request as ready for review June 12, 2024 13:06
@1uc 1uc requested review from JCGoran and pramodk June 12, 2024 13:06

@pramodk pramodk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
(I added a comment just to have future notes (as slack history will disappear one day))

Comment thread src/codegen/codegen_neuron_cpp_visitor.cpp
@1uc 1uc merged commit e9e127a into master Jun 13, 2024
@1uc 1uc deleted the 1uc/top-local branch June 13, 2024 07:48
JCGoran pushed a commit to neuronsimulator/nrn that referenced this pull request Mar 12, 2025
These are global variables, and when THREAD_SAFE act like thread
variables, without being exposed to HOC/Python.

NMODL Repo SHA: BlueBrain/nmodl@e9e127a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants