This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Fix integration tests.#1313
Merged
Merged
Conversation
There must not be a clash of FUNCTION and RANGE names.
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jun 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1313 +/- ##
=======================================
Coverage 85.54% 85.54%
=======================================
Files 178 178
Lines 13415 13415
=======================================
Hits 11476 11476
Misses 1939 1939 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Logfiles from GitLab pipeline #216396 (:white_check_mark:) have been uploaded here! Status and direct links: |
JCGoran
approved these changes
Jun 12, 2024
JCGoran
left a comment
Contributor
There was a problem hiding this comment.
For context, nrnivmodl fails with:
Error: alfa used as both variable and function in file glia_sparse.mod
while nmodl --neuron generates the file without issues, which it shouldn't.
Collaborator
Author
|
There's (now) a ticket for the issue: #1316 |
JCGoran
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 12, 2025
There must not be a clash of FUNCTION and RANGE names. NMODL Repo SHA: BlueBrain/nmodl@d226bef
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There must not be a clash of FUNCTION and RANGE names.