Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Lift shared code for KINETIC.#1312

Merged
1uc merged 2 commits into
masterfrom
1uc/kinetic
Jun 12, 2024
Merged

Lift shared code for KINETIC.#1312
1uc merged 2 commits into
masterfrom
1uc/kinetic

Conversation

@1uc

@1uc 1uc commented Jun 12, 2024

Copy link
Copy Markdown
Collaborator

No description provided.

@bbpbuildbot

This comment has been minimized.

bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jun 12, 2024
@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #216457 (:no_entry:) have been uploaded here!

Status and direct links:

@codecov

codecov Bot commented Jun 12, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 69.64286% with 34 lines in your changes missing coverage. Please review.

Project coverage is 85.46%. Comparing base (13550d7) to head (887de45).
Report is 1 commits behind head on master.

Files Patch % Lines
src/codegen/codegen_cpp_visitor.cpp 71.84% 29 Missing ⚠️
src/codegen/codegen_neuron_cpp_visitor.cpp 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1312      +/-   ##
==========================================
- Coverage   85.49%   85.46%   -0.03%     
==========================================
  Files         178      178              
  Lines       13367    13379      +12     
==========================================
+ Hits        11428    11435       +7     
- Misses       1939     1944       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1uc 1uc marked this pull request as ready for review June 12, 2024 10:17
@1uc 1uc requested review from JCGoran and pramodk June 12, 2024 10:17
Comment thread test/usecases/kinetic/X2Y.mod
@1uc 1uc merged commit 8679d7e into master Jun 12, 2024
@1uc 1uc deleted the 1uc/kinetic branch June 12, 2024 11:07
JCGoran pushed a commit to neuronsimulator/nrn that referenced this pull request Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants