This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Consistently use _lmc and references.#1309
Merged
Merged
Conversation
Frequently `_lmr` is passed by pointer, which requires printing: ``` foo(&_lmr, ...); ``` the `&` is annoying, because it prevents us from using `get_arg_str`. It also sometimes leads us to do: ``` auto * _ml = &_lmr; ``` which is bad, because it's not a `Memb_list`.
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jun 11, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1309 +/- ##
==========================================
+ Coverage 85.54% 85.57% +0.02%
==========================================
Files 178 178
Lines 13415 13410 -5
==========================================
- Hits 11476 11475 -1
+ Misses 1939 1935 -4 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Logfiles from GitLab pipeline #216114 (:white_check_mark:) have been uploaded here! Status and direct links: |
Contributor
What's the meaning of the leading |
Collaborator
Author
|
In |
JCGoran
approved these changes
Jun 12, 2024
JCGoran
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 12, 2025
Frequently `_lmr` is passed by pointer, which requires printing: ``` foo(&_lmr, ...); ``` the `&` is annoying, because it prevents us from using `get_arg_str`. It also sometimes leads us to do: ``` auto * _ml = &_lmr; ``` which is bad, because it's not a `Memb_list`. * Rename '_lmr' to '_lmc'. NMODL Repo SHA: BlueBrain/nmodl@13550d7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frequently
_lmris passed by pointer, which requires printing:the
&is annoying, because it prevents us from usingget_arg_str. Italso sometimes leads us to do:
which is bad, because it's not a
Memb_list.In a second step we rename
_lmrto_lmcwhich is short formechanism_cachewhich is better since the_rangepart can also be_instance.