This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Modernize NMODL -> Python layer.#1306
Merged
Merged
Conversation
The executable from the Python library.
It's unclear why we need to set it. If we do, it's not clear why it would would be able to pick up modules from `venv`s.
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jun 7, 2024
This comment has been minimized.
This comment has been minimized.
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jun 7, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1306 +/- ##
==========================================
- Coverage 85.54% 85.46% -0.08%
==========================================
Files 178 178
Lines 13415 13372 -43
==========================================
- Hits 11476 11429 -47
- Misses 1939 1943 +4 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jun 7, 2024
90c947b to
7b3baed
Compare
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jun 7, 2024
This comment has been minimized.
This comment has been minimized.
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jun 7, 2024
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jun 7, 2024
This comment has been minimized.
This comment has been minimized.
0480e1f to
fea7491
Compare
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jun 7, 2024
This comment has been minimized.
This comment has been minimized.
pramodk
approved these changes
Jun 10, 2024
pramodk
left a comment
Contributor
There was a problem hiding this comment.
I didn't check every single changed line from src/pybind/wrapper.cpp but overall these are certainly nice improvements and make it clear/concise!
Collaborator
Author
|
Double checked the issue about |
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jun 11, 2024
Collaborator
|
Logfiles from GitLab pipeline #216169 (:white_check_mark:) have been uploaded here! Status and direct links: |
JCGoran
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 12, 2025
The changes are: * Don't forcefully set the PYTHONPATH. * Replace false object oriented code with a function (each). * Replace a global variable, with a function to initialize. * Use a reference for a pointer that's should never be a nullptr. NMODL Repo SHA: BlueBrain/nmodl@2636b4e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes are:
nullptr.