This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Remove generation of INCLUDE file in the tests#1295
Merged
Conversation
- include mod files generation cause race condition with parallel tests, see #1290 - the included files are trivial examples for testing and they don't need to be generated from the code - could be copied via configure_file - cmake could generate those at a configure time Considering the use case and it's triviality, I thought 2nd option is better. That also allows to remove some extra code/logic.
alkino
approved these changes
Jun 3, 2024
This comment has been minimized.
This comment has been minimized.
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jun 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1295 +/- ##
=======================================
Coverage 85.49% 85.49%
=======================================
Files 178 178
Lines 13448 13436 -12
=======================================
- Hits 11497 11487 -10
+ Misses 1951 1949 -2 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Logfiles from GitLab pipeline #214695 (:white_check_mark:) have been uploaded here! Status and direct links: |
1uc
approved these changes
Jun 4, 2024
1uc
left a comment
Collaborator
There was a problem hiding this comment.
It ran several times without issues.
Closed
JCGoran
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 12, 2025
* Remove INCLUDE mod file generation in tests - include mod files generation cause race condition with parallel tests, see BlueBrain/nmodl#1290 - the included files are trivial examples for testing and they don't need to be generated from the code - could be copied via configure_file - cmake could generate those at a configure time Considering the use case and it's triviality, I thought 2nd option is better. That also allows to remove some extra code/logic. NMODL Repo SHA: BlueBrain/nmodl@844e6bd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ctest --parallel#1290Considering the use case and it's triviality, I thought 2nd option is better. That also allows removal of some extra code/logic.