Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Fix missing SUFFIX.#1293

Merged
1uc merged 6 commits into
masterfrom
1uc/default-suffix
Jun 4, 2024
Merged

Fix missing SUFFIX.#1293
1uc merged 6 commits into
masterfrom
1uc/default-suffix

Conversation

@1uc

@1uc 1uc commented Jun 3, 2024

Copy link
Copy Markdown
Collaborator

The default is the stem of the mod file.

bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jun 3, 2024
@codecov

codecov Bot commented Jun 3, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.49%. Comparing base (5366532) to head (9842ff6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1293   +/-   ##
=======================================
  Coverage   85.49%   85.49%           
=======================================
  Files         178      178           
  Lines       13448    13450    +2     
=======================================
+ Hits        11497    11499    +2     
  Misses       1951     1951           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

@1uc 1uc force-pushed the 1uc/default-suffix branch from ad707f2 to 8afb2e9 Compare June 4, 2024 07:04
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jun 4, 2024
@1uc 1uc marked this pull request as ready for review June 4, 2024 08:06
@1uc

1uc commented Jun 4, 2024

Copy link
Copy Markdown
Collaborator Author

Fixes #1226

@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #214694 (:white_check_mark:) have been uploaded here!

Status and direct links:

@JCGoran JCGoran left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@1uc 1uc merged commit 73bf358 into master Jun 4, 2024
@1uc 1uc deleted the 1uc/default-suffix branch June 4, 2024 11:56
JCGoran pushed a commit to neuronsimulator/nrn that referenced this pull request Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants