Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Use ParamVector everywhere#1289

Merged
JCGoran merged 12 commits into
masterfrom
jelic/cleanup_paramvector
Jun 4, 2024
Merged

Use ParamVector everywhere#1289
JCGoran merged 12 commits into
masterfrom
jelic/cleanup_paramvector

Conversation

@JCGoran

@JCGoran JCGoran commented Jun 3, 2024

Copy link
Copy Markdown
Contributor

Also refactored some functions so they don't use char* but a std::string instead.

@bbpbuildbot

This comment has been minimized.

bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jun 3, 2024
@codecov

codecov Bot commented Jun 3, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 88.88889% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.54%. Comparing base (b4ef537) to head (ae6be8c).
Report is 6 commits behind head on master.

Files Patch % Lines
src/codegen/codegen_neuron_cpp_visitor.cpp 82.35% 3 Missing ⚠️
src/codegen/codegen_coreneuron_cpp_visitor.cpp 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1289      +/-   ##
==========================================
+ Coverage   85.50%   85.54%   +0.04%     
==========================================
  Files         178      178              
  Lines       13446    13415      -31     
==========================================
- Hits        11497    11476      -21     
+ Misses       1949     1939      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

@JCGoran JCGoran marked this pull request as ready for review June 3, 2024 14:19
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jun 3, 2024
@bbpbuildbot

This comment has been minimized.

Comment thread src/codegen/codegen_cpp_visitor.cpp
Comment thread src/codegen/codegen_neuron_cpp_visitor.cpp Outdated
Comment thread src/codegen/codegen_coreneuron_cpp_visitor.cpp Outdated
@bbpbuildbot

This comment has been minimized.

bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jun 4, 2024
@JCGoran JCGoran requested a review from 1uc June 4, 2024 11:06
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jun 4, 2024
@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request Jun 4, 2024
@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #214914 (:white_check_mark:) have been uploaded here!

Status and direct links:

@JCGoran JCGoran merged commit 3754a71 into master Jun 4, 2024
@JCGoran JCGoran deleted the jelic/cleanup_paramvector branch June 4, 2024 14:47
JCGoran added a commit to neuronsimulator/nrn that referenced this pull request Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants