This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Fix PROCEDUREs using TABLEs containing the same var#1280
Merged
Conversation
Merged
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
May 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1280 +/- ##
==========================================
+ Coverage 86.22% 86.24% +0.01%
==========================================
Files 178 178
Lines 13281 13299 +18
==========================================
+ Hits 11452 11470 +18
Misses 1829 1829 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
1uc
reviewed
May 29, 2024
1uc
reviewed
May 29, 2024
added 2 commits
May 29, 2024 10:05
1uc
approved these changes
May 29, 2024
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
May 29, 2024
Collaborator
|
Logfiles from GitLab pipeline #213387 (:white_check_mark:) have been uploaded here! Status and direct links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds a test to it.
Context
In #1247 (comment) we found out that the same variable cannot be used in multiple TABLE statements using NOCMODL, so this PR adds a run-time check that prohibits this in NMODL as well.