Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Fix missing variables when calling a FUNCTION or PROCEDURE in BREAKPOINT block#1260

Merged
1uc merged 10 commits into
masterfrom
jelic/fix_missing_vars_again
May 16, 2024
Merged

Fix missing variables when calling a FUNCTION or PROCEDURE in BREAKPOINT block#1260
1uc merged 10 commits into
masterfrom
jelic/fix_missing_vars_again

Conversation

@JCGoran

@JCGoran JCGoran commented May 14, 2024

Copy link
Copy Markdown
Contributor

No description provided.

bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request May 14, 2024
@JCGoran JCGoran marked this pull request as ready for review May 14, 2024 11:22
@codecov-commenter

codecov-commenter commented May 14, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 86.32%. Comparing base (49da686) to head (42e4bd8).

Files Patch % Lines
src/codegen/codegen_neuron_cpp_visitor.cpp 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1260      +/-   ##
==========================================
- Coverage   86.35%   86.32%   -0.04%     
==========================================
  Files         175      175              
  Lines       13214    13219       +5     
==========================================
  Hits        11411    11411              
- Misses       1803     1808       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

@1uc 1uc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also consider comments made here:
BlueBrain/nmodl-references#18

Comment thread test/usecases/nonspecific_current/leonhard.mod Outdated
Goran Jelic-Cizmek added 2 commits May 15, 2024 09:51
@JCGoran JCGoran mentioned this pull request May 15, 2024
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request May 15, 2024
@bbpbuildbot

This comment has been minimized.

bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request May 15, 2024
@bbpbuildbot

This comment has been minimized.

Comment thread test/usecases/func_in_breakpoint/func_in_breakpoint.mod Outdated
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request May 15, 2024
@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #211280 (:white_check_mark:) have been uploaded here!

Status and direct links:

@1uc 1uc merged commit a8f1829 into master May 16, 2024
@1uc 1uc deleted the jelic/fix_missing_vars_again branch May 16, 2024 05:11
JCGoran added a commit to neuronsimulator/nrn that referenced this pull request Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants