Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Rework references.#1254

Merged
1uc merged 35 commits into
masterfrom
1uc/remove-references
May 14, 2024
Merged

Rework references.#1254
1uc merged 35 commits into
masterfrom
1uc/remove-references

Conversation

@1uc

@1uc 1uc commented May 8, 2024

Copy link
Copy Markdown
Collaborator

The idea is to generate the references, but not check that there are no differences. Doing so allows us to push the changes automatically to nmodl-references.

@bbpbuildbot

This comment has been minimized.

@codecov-commenter

codecov-commenter commented May 10, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.35%. Comparing base (299c249) to head (ee8e043).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1254      +/-   ##
==========================================
- Coverage   86.36%   86.35%   -0.01%     
==========================================
  Files         176      175       -1     
  Lines       13227    13214      -13     
==========================================
- Hits        11423    11411      -12     
+ Misses       1804     1803       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

@1uc 1uc force-pushed the 1uc/remove-references branch from 8e56683 to 754e9d5 Compare May 13, 2024 13:10
@1uc 1uc force-pushed the 1uc/remove-references branch from 5667967 to 91b13bd Compare May 13, 2024 15:10
@bbpbuildbot

This comment has been minimized.

bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request May 14, 2024
@bbpbuildbot

This comment has been minimized.

@1uc 1uc marked this pull request as ready for review May 14, 2024 06:27
bbpadministrator pushed a commit to BlueBrain/nmodl-references that referenced this pull request May 14, 2024
@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #210831 (:white_check_mark:) have been uploaded here!

Status and direct links:

@1uc 1uc requested review from JCGoran, matz-e and ohm314 May 14, 2024 08:45

@JCGoran JCGoran left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick: could we put the URL of the branch of nmodl-references we are pushing to in the CI log? Just so we don't need to enter the URL by hand. A simple echo "Pushed to: https://github.com/BlueBrain/nmodl-references/tree/${branch}" would do since I think GH detects URLs. Other than that, LGTM.

@1uc 1uc merged commit 0e69948 into master May 14, 2024
@1uc 1uc deleted the 1uc/remove-references branch May 14, 2024 09:05
@1uc

1uc commented May 14, 2024

Copy link
Copy Markdown
Collaborator Author

The commit mentions this PR. Hence, it appears in the timeline.

Comment thread .github/workflows/nmodl-ci.yml
Comment thread .github/workflows/nmodl-ci.yml
JCGoran pushed a commit to neuronsimulator/nrn that referenced this pull request Mar 12, 2025
The idea is to generate the references, but not check that there are no differences. Doing so allows us to push the changes automatically to `nmodl-references`.

NMODL Repo SHA: BlueBrain/nmodl@0e69948
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants