This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Move common codegen code to parent class CodegenCppVisitor#1251
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
CodegenCppVisitor
This comment has been minimized.
This comment has been minimized.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1251 +/- ##
==========================================
- Coverage 86.36% 86.35% -0.01%
==========================================
Files 176 175 -1
Lines 13227 13214 -13
==========================================
- Hits 11423 11411 -12
+ Misses 1804 1803 -1 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Logfiles from GitLab pipeline #210557 (:white_check_mark:) have been uploaded here! Status and direct links: |
alkino
approved these changes
May 13, 2024
This was referenced May 22, 2024
Merged
JCGoran
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the codegen routines are identical for NEURON and coreNEURON, so we may as well put them in the parent class, notably:
print_function_or_procedurevin NEURON codegen)print_table_replacement_function(code in Add TABLE statement #1247 does not actually need modifying)print_table_check_functionget_table_statementcheck_if_var_is_arrayprint_function_declaration