Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Fix missing variables when calling functions or procedures in INITIAL block#1248

Merged
1uc merged 5 commits into
masterfrom
jelic/fix_missing_vars
May 7, 2024
Merged

Fix missing variables when calling functions or procedures in INITIAL block#1248
1uc merged 5 commits into
masterfrom
jelic/fix_missing_vars

Conversation

@JCGoran

@JCGoran JCGoran commented May 3, 2024

Copy link
Copy Markdown
Contributor

The variables _ml, _thread, and _ppvar are needed when calling functions or procedures in the INITIAL block.

@JCGoran JCGoran added the NEURON codegen Work toward NEURON code generation label May 3, 2024
@bbpbuildbot

This comment has been minimized.

@JCGoran JCGoran marked this pull request as ready for review May 3, 2024 13:23
Comment thread test/usecases/CMakeLists.txt Outdated
@codecov-commenter

codecov-commenter commented May 3, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.66%. Comparing base (8285f26) to head (0dbadca).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1248   +/-   ##
=======================================
  Coverage   86.66%   86.66%           
=======================================
  Files         176      176           
  Lines       13164    13167    +3     
=======================================
+ Hits        11408    11411    +3     
  Misses       1756     1756           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JCGoran JCGoran changed the title Fix missing variables when calling functions or procedures Fix missing variables when calling functions or procedures in INITIAL block May 3, 2024
@bbpbuildbot

This comment has been minimized.

@JCGoran JCGoran requested a review from pramodk May 6, 2024 07:23
@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #209589 (:white_check_mark:) have been uploaded here!

Status and direct links:

@JCGoran JCGoran requested a review from 1uc May 7, 2024 08:07
@1uc 1uc merged commit b3dd6f1 into master May 7, 2024
@1uc 1uc deleted the jelic/fix_missing_vars branch May 7, 2024 12:55
JCGoran added a commit to neuronsimulator/nrn that referenced this pull request Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NEURON codegen Work toward NEURON code generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants