This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Fix dependency issues when included in NRN.#1243
Merged
Merged
Conversation
e697735 to
d76fa4d
Compare
This comment has been minimized.
This comment has been minimized.
d76fa4d to
65846e3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1243 +/- ##
=======================================
Coverage 86.56% 86.56%
=======================================
Files 176 176
Lines 13170 13170
=======================================
Hits 11400 11400
Misses 1770 1770 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Logfiles from GitLab pipeline #205929 (:white_check_mark:) have been uploaded here! Status and direct links: |
alkino
approved these changes
Apr 18, 2024
JCGoran
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 12, 2025
In NRN we depend on the target `nmodl` to ensure that when we run `nrnivmodl -coreneuron` the binary `nmodl` exists. We need to also ensure that everything `nmodl` needs to works is present. This fixes a dependency bug on certain copied files by making the target for copying the files a dependency of `nmodl`. NMODL Repo SHA: BlueBrain/nmodl@b78c3f3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In NRN we depend on the target
nmodlto ensure that when we runnrnivmodl -coreneuronthe binarynmodlexists. We need to also ensure that everythingnmodlneeds to works is present.This fixes a dependency bug on certain copied files by making the target for copying the files a dependency of
nmodl.