Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Check python compile-time vs runtime#1242

Merged
alkino merged 2 commits into
masterfrom
cornu/python_check_version
Apr 17, 2024
Merged

Check python compile-time vs runtime#1242
alkino merged 2 commits into
masterfrom
cornu/python_check_version

Conversation

@alkino

@alkino alkino commented Apr 17, 2024

Copy link
Copy Markdown
Member

the ABI otherwise is not the same and can lead to segfaults

@alkino alkino requested a review from 1uc April 17, 2024 13:36
@bbpbuildbot

This comment has been minimized.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 86.58%. Comparing base (868ce13) to head (52492a5).

Files Patch % Lines
src/pybind/pyembed.cpp 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1242      +/-   ##
==========================================
- Coverage   86.63%   86.58%   -0.06%     
==========================================
  Files         176      176              
  Lines       13159    13167       +8     
==========================================
  Hits        11400    11400              
- Misses       1759     1767       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alkino alkino requested a review from pramodk April 17, 2024 15:23
Comment thread src/pybind/pyembed.cpp
Comment thread src/pybind/pyembed.cpp Outdated
Comment thread src/pybind/pyembed.cpp Outdated
@alkino alkino force-pushed the cornu/python_check_version branch from e60c158 to 651d38b Compare April 17, 2024 15:39
@alkino alkino force-pushed the cornu/python_check_version branch from 651d38b to 924e48d Compare April 17, 2024 15:40
@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #205835 (:white_check_mark:) have been uploaded here!

Status and direct links:

@alkino alkino merged commit bb5355f into master Apr 17, 2024
@alkino alkino deleted the cornu/python_check_version branch April 17, 2024 16:29
JCGoran pushed a commit to neuronsimulator/nrn that referenced this pull request Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants