Launch Python embedded interpreter only if using sympy#1241
Conversation
This comment has been minimized.
This comment has been minimized.
|
We need to check that it can still compile a MOD file containing a KINETIC block. The suspicion is that a KINETIC block will ask for sympy even if the subcommand The other question is if we can do away with the initialization code entirely. I think there's a singleton that represents "access to Python". Maybe we can initialize the singleton properly when we first use it (and no sooner). |
7788eda to
bef0df9
Compare
This comment has been minimized.
This comment has been minimized.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1241 +/- ##
==========================================
- Coverage 86.56% 86.50% -0.06%
==========================================
Files 176 176
Lines 13170 13171 +1
==========================================
- Hits 11400 11393 -7
- Misses 1770 1778 +8 ☔ View full report in Codecov by Sentry. |
|
Logfiles from GitLab pipeline #206012 (:no_entry:) have been uploaded here! Status and direct links: |
|
I tried to find places where the embedded Python is used, but I only found the Sympy related stuff. Then I check if Sympy is used within a different visitor; but didn't find anything. Therefore, this looks correct to me. |
No description provided.