Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Launch Python embedded interpreter only if using sympy#1241

Merged
alkino merged 4 commits into
masterfrom
launch_python_sympy_opt
Apr 18, 2024
Merged

Launch Python embedded interpreter only if using sympy#1241
alkino merged 4 commits into
masterfrom
launch_python_sympy_opt

Conversation

@alkino

@alkino alkino commented Apr 16, 2024

Copy link
Copy Markdown
Member

No description provided.

@bbpbuildbot

This comment has been minimized.

@1uc

1uc commented Apr 18, 2024

Copy link
Copy Markdown
Collaborator

We need to check that it can still compile a MOD file containing a KINETIC block. The suspicion is that a KINETIC block will ask for sympy even if the subcommand sympy wasn't requested.

The other question is if we can do away with the initialization code entirely. I think there's a singleton that represents "access to Python". Maybe we can initialize the singleton properly when we first use it (and no sooner).

Comment thread src/main.cpp Outdated
@alkino alkino force-pushed the launch_python_sympy_opt branch from 7788eda to bef0df9 Compare April 18, 2024 08:26
@alkino alkino requested a review from 1uc April 18, 2024 08:48
@bbpbuildbot

This comment has been minimized.

@codecov-commenter

codecov-commenter commented Apr 18, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 5.26316% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 86.50%. Comparing base (b78c3f3) to head (bef0df9).

❗ Current head bef0df9 differs from pull request most recent head 081ac76. Consider uploading reports for the commit 081ac76 to get more accurate results

Files Patch % Lines
src/main.cpp 5.26% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1241      +/-   ##
==========================================
- Coverage   86.56%   86.50%   -0.06%     
==========================================
  Files         176      176              
  Lines       13170    13171       +1     
==========================================
- Hits        11400    11393       -7     
- Misses       1770     1778       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #206012 (:no_entry:) have been uploaded here!

Status and direct links:

@1uc

1uc commented Apr 18, 2024

Copy link
Copy Markdown
Collaborator

I tried to find places where the embedded Python is used, but I only found the Sympy related stuff. Then I check if Sympy is used within a different visitor; but didn't find anything.

Therefore, this looks correct to me.

@alkino alkino merged commit df2343e into master Apr 18, 2024
@alkino alkino deleted the launch_python_sympy_opt branch April 18, 2024 12:05
JCGoran pushed a commit to neuronsimulator/nrn that referenced this pull request Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants