Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Implement simplified expsyn.#1238

Merged
1uc merged 3 commits into
masterfrom
1uc/snapsyn
May 7, 2024
Merged

Implement simplified expsyn.#1238
1uc merged 3 commits into
masterfrom
1uc/snapsyn

Conversation

@1uc

@1uc 1uc commented Apr 15, 2024

Copy link
Copy Markdown
Collaborator

Instead of setting the conductance as:

g = g + g0 * exp(-(t - t0)/tau)

we set it to

g += g0

where g0 is the argument passed to NET_RECEIVE, i.e. the weight.

This allows for an analytic solution, that can be tested.

@bbpbuildbot

This comment has been minimized.

@1uc 1uc marked this pull request as ready for review April 16, 2024 07:21
@codecov-commenter

codecov-commenter commented Apr 16, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 13.46154% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 86.40%. Comparing base (b3dd6f1) to head (7f9c69e).

Files Patch % Lines
src/codegen/codegen_neuron_cpp_visitor.cpp 13.46% 45 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1238      +/-   ##
==========================================
- Coverage   86.67%   86.40%   -0.27%     
==========================================
  Files         176      176              
  Lines       13166    13213      +47     
==========================================
+ Hits        11411    11417       +6     
- Misses       1755     1796      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

Comment thread src/codegen/codegen_neuron_cpp_visitor.cpp Outdated
1uc added 3 commits May 7, 2024 15:00
Instead of setting the conductance as:

  g = g + g0 * exp(-(t - t0)/tau)

we set it to
  g += g0

where `g0` is the argument passed to NET_RECEIVE, i.e. the weight.

This allows for an analytic solution, that can be tested.
@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #209730 (:white_check_mark:) have been uploaded here!

Status and direct links:

@1uc 1uc merged commit ada65df into master May 7, 2024
@1uc 1uc deleted the 1uc/snapsyn branch May 7, 2024 15:01
JCGoran pushed a commit to neuronsimulator/nrn that referenced this pull request Mar 12, 2025
Instead of setting the conductance as:

  g = g + g0 * exp(-(t - t0)/tau)

we set it to
  g += g0

where `g0` is the argument passed to NET_RECEIVE, i.e. the weight.

This allows for an analytic solution, that can be tested.

NMODL Repo SHA: BlueBrain/nmodl@ada65df
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants