This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Add dependency of generate_references on nmodl.#1234
Merged
Conversation
This can be reproduced by:
cmake -B build && cmake --build build --target=generate_references
i.e. call `--target=generate_references` without building it first. It
would complain about missing `bin/nmodl`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1234 +/- ##
=======================================
Coverage 86.59% 86.59%
=======================================
Files 176 176
Lines 13053 13053
=======================================
Hits 11303 11303
Misses 1750 1750 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Logfiles from GitLab pipeline #203794 (:white_check_mark:) have been uploaded here! Status and direct links: |
alkino
approved these changes
Apr 5, 2024
JCGoran
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 12, 2025
…1234) This can be reproduced by: cmake -B build && cmake --build build --target=generate_references i.e. call `--target=generate_references` without building it first. It would complain about missing `bin/nmodl`. NMODL Repo SHA: BlueBrain/nmodl@735b11d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be reproduced by:
i.e. call
--target=generate_referenceswithout building it first. It would complain about missingbin/nmodl.