This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Fix array variables.#1233
Merged
Merged
Conversation
pramodk
approved these changes
Apr 5, 2024
pramodk
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Let's see about the CI status, Azure failure looks spurious.
This comment has been minimized.
This comment has been minimized.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1233 +/- ##
=======================================
Coverage 86.56% 86.56%
=======================================
Files 176 176
Lines 13170 13175 +5
=======================================
+ Hits 11400 11405 +5
Misses 1770 1770 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
a588681 to
c1ef975
Compare
These are the code generation changes required for:
neuronsimulator/nrn#2779
The solution is to fill `nrn_prop_param_size` with the number of
doubles, not number of variables.
f3682e6 to
6031952
Compare
Collaborator
|
Logfiles from GitLab pipeline #206108 (:white_check_mark:) have been uploaded here! Status and direct links: |
JCGoran
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 12, 2025
* Fix array variables.
These are the code generation changes required for:
#2779
The solution is to fill `nrn_prop_param_size` with the number of
doubles, not number of variables.
NMODL Repo SHA: BlueBrain/nmodl@f6821ce
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the code generation changes required for:
The solution is to fill
nrn_prop_param_sizewith the number of doubles, not number of variables.