This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Add debug logging to parser#1229
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1229 +/- ##
=======================================
Coverage 86.50% 86.50%
=======================================
Files 176 176
Lines 13171 13175 +4
=======================================
+ Hits 11393 11397 +4
Misses 1778 1778 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
in principle, can be useful, I think. can you actually show the output with |
Collaborator
|
It certainly doesn't help with #1217 but if it's useful to you, we can merge it. |
1uc
approved these changes
Mar 26, 2024
Collaborator
|
Logfiles from GitLab pipeline #206124 (:white_check_mark:) have been uploaded here! Status and direct links: |
Contributor
|
Looks helpful IMO! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case of issues like #1217, we get a very short log trace like the below:
With this change, we can run with
--verbose traceto get more information what went wrong:See trace.log for the full output of the parser.
Of course,
--verbose tracewill also work if we have a valid file as well.Some implementation notes:
logger->[LEVEL]throughout the codebase because our custom wrapper class isn't actually used, so I opted for adding it to the driver instead to keep things simplestd::cerr. I tried to work my way around it, but ended up with segfaults due to a race condition, so I'm leaving that part out for now