This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Add minor fixes to generate_references on MacOS#1228
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1228 +/- ##
=======================================
Coverage 86.57% 86.57%
=======================================
Files 176 176
Lines 13049 13049
=======================================
Hits 11297 11297
Misses 1752 1752 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Logfiles from GitLab pipeline #201376 (:white_check_mark:) have been uploaded here! Status and direct links: |
1uc
reviewed
Mar 21, 2024
1uc
approved these changes
Mar 21, 2024
alkino
reviewed
Mar 21, 2024
ohm314
pushed a commit
that referenced
this pull request
May 21, 2024
JCGoran
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, the previous version treated the quotation marks as literal, so it kept littering the
referencesdir with backup files which had''appended to it. This one expands the variables properly (thanks bash for arrays!). Also,realpathmay not exist on MacOS (of course...) so I've replaced it withcd "$(dirname "$0")"; pwd -Pwhich should do the same thing cross-platform.