Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Unroll kinetic blocks.#1214

Merged
pramodk merged 3 commits into
masterfrom
1uc/unroll-kinetic-blocks
Apr 5, 2024
Merged

Unroll kinetic blocks.#1214
pramodk merged 3 commits into
masterfrom
1uc/unroll-kinetic-blocks

Conversation

@1uc

@1uc 1uc commented Mar 12, 2024

Copy link
Copy Markdown
Collaborator

Fixes part of a bug related to reaction equations inside loops.

@1uc 1uc force-pushed the 1uc/unroll-kinetic-blocks branch from a568740 to daa145d Compare March 12, 2024 09:26
Comment thread test/unit/visitor/kinetic_block.cpp
@bbpbuildbot

This comment has been minimized.

@1uc 1uc marked this pull request as ready for review March 12, 2024 10:06
@codecov-commenter

codecov-commenter commented Mar 13, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.59%. Comparing base (9873e06) to head (3140e7f).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1214      +/-   ##
==========================================
+ Coverage   86.57%   86.59%   +0.01%     
==========================================
  Files         176      176              
  Lines       13049    13053       +4     
==========================================
+ Hits        11297    11303       +6     
+ Misses       1752     1750       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

1uc added 2 commits March 26, 2024 09:14
Fixes part of a bug related to reaction equations inside loops.
@1uc 1uc force-pushed the 1uc/unroll-kinetic-blocks branch from 3583fac to c5c918d Compare March 26, 2024 08:14
@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #202283 (:white_check_mark:) have been uploaded here!

Status and direct links:

@pramodk pramodk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pramodk pramodk merged commit 98e6df2 into master Apr 5, 2024
@pramodk pramodk deleted the 1uc/unroll-kinetic-blocks branch April 5, 2024 08:14
JCGoran pushed a commit to neuronsimulator/nrn that referenced this pull request Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants