This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Fix indexed COMPARTMENT block.#1209
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1209 +/- ##
==========================================
+ Coverage 86.55% 86.60% +0.04%
==========================================
Files 176 176
Lines 13017 13047 +30
==========================================
+ Hits 11267 11299 +32
+ Misses 1750 1748 -2 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
We'll want to merge #1206 first. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1uc
commented
Mar 11, 2024
This comment has been minimized.
This comment has been minimized.
matz-e
reviewed
Mar 12, 2024
matz-e
left a comment
Member
There was a problem hiding this comment.
I sort of feel like I've read that std::regex is not too performant, and the use here seems a wee bit excessive. But I guess we don't need to be supremely performant and it is concise.
When encountering an indexed `COMPARTMENT` block:
COMPARTMENT i, volume_expr { species }
All state variables are searched if they match they match the pattern
`"{species}[%d]"`. For each matching state variables, we obtain the
value of the array index and substitute the name of the array index with
its value in `volume_expr`. This is then stored in the array of
compartment factors.
Check that the resulting derivatives are divided by the volume of the compartment.
Collaborator
|
Logfiles from GitLab pipeline #199851 (:white_check_mark:) have been uploaded here! Status and direct links: |
matz-e
approved these changes
Mar 12, 2024
ohm314
pushed a commit
that referenced
this pull request
May 21, 2024
When encountering an indexed `COMPARTMENT` block:
COMPARTMENT i, volume_expr { species }
All state variables are searched if they match they match the pattern
`"{species}[%d]"`. For each matching state variables, we obtain the
value of the array index and substitute the name of the array index with
its value in `volume_expr`. This is then stored in the array of
compartment factors.
Check that the resulting derivatives are divided by the volume
of the compartment.
JCGoran
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 12, 2025
When encountering an indexed `COMPARTMENT` block:
COMPARTMENT i, volume_expr { species }
All state variables are searched if they match they match the pattern
`"{species}[%d]"`. For each matching state variables, we obtain the
value of the array index and substitute the name of the array index with
its value in `volume_expr`. This is then stored in the array of
compartment factors.
Check that the resulting derivatives are divided by the volume
of the compartment.
NMODL Repo SHA: BlueBrain/nmodl@219a3ed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When encountering an indexed
COMPARTMENTblock:All state variables are searched if they match they match the pattern
"{species}[%d]". For each matching state variables, we obtain thevalue of the array index and substitute the name of the array index with
its value in
volume_expr. This is then stored in the array ofcompartment factors.
If multiple species are listed, the above happens for each (array-valued) species.