This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Fail for invalid << reaction equation.#1204
Merged
Merged
Conversation
The previous behaviour for
KINETIC states {
~ x + y << 42.0
}
was to print a warning and continue as if the line didn't exist. The new
behaviour is to throw an error, because it's unclear why ignoring the
line could ever lead to a correct translation of the MOD file.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1204 +/- ##
==========================================
- Coverage 86.58% 86.57% -0.01%
==========================================
Files 175 175
Lines 13006 13002 -4
==========================================
- Hits 11261 11257 -4
Misses 1745 1745 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Logfiles from GitLab pipeline #199095 (:white_check_mark:) have been uploaded here! Status and direct links: |
matz-e
approved these changes
Mar 11, 2024
ohm314
pushed a commit
that referenced
this pull request
May 21, 2024
The previous behaviour for
KINETIC states {
~ x + y << 42.0
}
was to print a warning and continue as if the line didn't exist. The new
behaviour is to throw an error, because it's unclear why ignoring the
line could ever lead to a correct translation of the MOD file.
JCGoran
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 12, 2025
The previous behaviour for
KINETIC states {
~ x + y << 42.0
}
was to print a warning and continue as if the line didn't exist. The new
behaviour is to throw an error, because it's unclear why ignoring the
line could ever lead to a correct translation of the MOD file.
NMODL Repo SHA: BlueBrain/nmodl@9292c18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous behaviour for
was to print a warning and continue as if the line didn't exist. The new behaviour is to throw an error, because it's unclear why ignoring the line could ever lead to a correct translation of the MOD file.