Skip to content
This repository was archived by the owner on Mar 25, 2025. It is now read-only.

Implement access to neuron global variables.#1192

Merged
1uc merged 2 commits into
masterfrom
1uc/neuron_variables
Mar 11, 2024
Merged

Implement access to neuron global variables.#1192
1uc merged 2 commits into
masterfrom
1uc/neuron_variables

Conversation

@1uc

@1uc 1uc commented Feb 29, 2024

Copy link
Copy Markdown
Collaborator

What's meant is things like celsius.

@1uc 1uc force-pushed the 1uc/neuron_variables branch from 25e3ae0 to 60121e8 Compare February 29, 2024 13:25
@bbpbuildbot

This comment has been minimized.

@1uc 1uc marked this pull request as ready for review February 29, 2024 15:38
Comment thread src/codegen/codegen_neuron_cpp_visitor.cpp
Comment thread test/usecases/parameter/simulate.py Outdated
Comment thread test/usecases/parameter/neuron_variables.mod Outdated
@bbpbuildbot

This comment has been minimized.

@1uc 1uc force-pushed the 1uc/neuron_variables branch 2 times, most recently from b978427 to 8ab2bdf Compare March 7, 2024 15:56
@bbpbuildbot

This comment has been minimized.

@codecov-commenter

codecov-commenter commented Mar 8, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 86.55%. Comparing base (40aa0bf) to head (8c290fd).

Files Patch % Lines
src/codegen/codegen_neuron_cpp_visitor.cpp 40.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1192      +/-   ##
==========================================
- Coverage   86.57%   86.55%   -0.03%     
==========================================
  Files         176      176              
  Lines       13009    13017       +8     
==========================================
+ Hits        11263    11267       +4     
- Misses       1746     1750       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

@1uc 1uc force-pushed the 1uc/neuron_variables branch from 4b22a65 to 8c290fd Compare March 11, 2024 10:32
@bbpbuildbot

Copy link
Copy Markdown
Collaborator

Logfiles from GitLab pipeline #199569 (:white_check_mark:) have been uploaded here!

Status and direct links:

@1uc 1uc merged commit c8818c8 into master Mar 11, 2024
@1uc 1uc deleted the 1uc/neuron_variables branch March 11, 2024 12:02
ohm314 pushed a commit that referenced this pull request May 21, 2024
What's meant is things like `celsius`.
JCGoran pushed a commit to neuronsimulator/nrn that referenced this pull request Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants