This repository was archived by the owner on Mar 25, 2025. It is now read-only.
Simplify CodegenCppVisitor#1076
Merged
Merged
Conversation
iomaganaris
commented
Sep 21, 2023
Contributor
- Rename C to C++ in multiple places
- Remove wrapper_printer and target_printer since we only print a single C++ file now for all the backends (C++, OpenACC/OpenMP). There is no more ISPC which needed the wrapper.
…e C++ file now for all the backends
tristan0x
approved these changes
Sep 21, 2023
tristan0x
left a comment
Member
There was a problem hiding this comment.
LGTM!
Sorry for the conflict @iomaganaris ¯_(ツ)_/¯
Contributor
Author
Haha no worries, it was nothing serious 😇 |
alkino
approved these changes
Sep 21, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1076 +/- ##
==========================================
- Coverage 70.19% 70.19% -0.01%
==========================================
Files 188 188
Lines 25632 25630 -2
==========================================
- Hits 17992 17990 -2
Misses 7640 7640
☔ View full report in Codecov by Sentry. |
Collaborator
|
Logfiles from GitLab pipeline #154703 (:white_check_mark:) have been uploaded here! Status and direct links: |
ohm314
pushed a commit
that referenced
this pull request
Oct 5, 2023
* Remove wrapper_printer and target_printer since we only print a single C++ file now for all the backends * Rename C to C++ in multiple places
JCGoran
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Mar 12, 2025
* Remove wrapper_printer and target_printer since we only print a single C++ file now for all the backends * Rename C to C++ in multiple places NMODL Repo SHA: BlueBrain/nmodl@f180a2d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.