Skip to content
This repository was archived by the owner on Jun 8, 2023. It is now read-only.

Only one WATCH statement can be triggered at a time#63

Merged
pramodk merged 2 commits into
masterfrom
psolve-direct
Jul 23, 2021
Merged

Only one WATCH statement can be triggered at a time#63
pramodk merged 2 commits into
masterfrom
psolve-direct

Conversation

@nrnhines

@nrnhines nrnhines commented Jun 1, 2021

Copy link
Copy Markdown
Contributor

Related to the psolve-direct PR for neuronsimulator/nrn#1192 .
Needed for successful test in that PR for test/coreneuron/mod/watchrange.mod

@pramodk pramodk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pramodk pramodk merged commit 9b474e9 into master Jul 23, 2021
pramodk added a commit to BlueBrain/CoreNeuron that referenced this pull request Jul 23, 2021
@olupton olupton mentioned this pull request Jul 23, 2021
1 task
@alexsavulescu alexsavulescu deleted the psolve-direct branch July 23, 2021 08:05
@alexsavulescu alexsavulescu restored the psolve-direct branch July 23, 2021 08:14
pramodk added a commit to BlueBrain/nmodl that referenced this pull request Jul 23, 2021
pramodk added a commit to BlueBrain/nmodl that referenced this pull request Jul 23, 2021
…les update on CPU/GPU (#710)

* fixed for watch statements, global variable on GPU
* fixed watch statement code generation described in #679
* fixed global variable update to gpu descrbed in #678
* fixed atomic capture for net_send buffer
* fixed for watch test on GPU
     - Initial block was missing net_send_buffering related codegen
       when net_send was used
     - fix indentation with watch if-else statements
     - net_send_buffer updates from host & device missing
     - net_receieve_buffer code was out of place
* Incorporate BlueBrain/mod2c/pull/63
* Fix CVF CI: INITIAL block shouldn't be executed on ISPC backend
   when mod file uses net_send/net_event method. This is because they
   contain non-compatible code for event buffering used for GPU.
* Fix the weight_index argument for net_send_buffering()
   generated for net_send() call in INITIAL block.
   - See analysis in #680

Closes #679, closes #678, closes #675, closes #680
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants