This repository was archived by the owner on Jun 8, 2023. It is now read-only.
Only one WATCH statement can be triggered at a time#63
Merged
Conversation
This was referenced Jun 1, 2021
This was referenced Jul 21, 2021
pramodk
added a commit
to BlueBrain/CoreNeuron
that referenced
this pull request
Jul 23, 2021
1 task
pramodk
added a commit
to BlueBrain/nmodl
that referenced
this pull request
Jul 23, 2021
pramodk
added a commit
to BlueBrain/nmodl
that referenced
this pull request
Jul 23, 2021
…les update on CPU/GPU (#710) * fixed for watch statements, global variable on GPU * fixed watch statement code generation described in #679 * fixed global variable update to gpu descrbed in #678 * fixed atomic capture for net_send buffer * fixed for watch test on GPU - Initial block was missing net_send_buffering related codegen when net_send was used - fix indentation with watch if-else statements - net_send_buffer updates from host & device missing - net_receieve_buffer code was out of place * Incorporate BlueBrain/mod2c/pull/63 * Fix CVF CI: INITIAL block shouldn't be executed on ISPC backend when mod file uses net_send/net_event method. This is because they contain non-compatible code for event buffering used for GPU. * Fix the weight_index argument for net_send_buffering() generated for net_send() call in INITIAL block. - See analysis in #680 Closes #679, closes #678, closes #675, closes #680
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to the psolve-direct PR for neuronsimulator/nrn#1192 .
Needed for successful test in that PR for test/coreneuron/mod/watchrange.mod