Improve support for sanitizers with AppleClang#144
Merged
Conversation
pramodk
reviewed
Sep 14, 2022
Comment on lines
+225
to
+228
| # Helper function strips away Python shims on macOS, so we can launch tests using the actual Python | ||
| # binary. Without this, preloading the sanitizer runtimes does not work on macOS. See | ||
| # https://jonasdevlieghere.com/sanitizing-python-modules/ and | ||
| # https://tobywf.com/2021/02/python-ext-asan/ for more information. |
There was a problem hiding this comment.
@pramodk thinking of SKIP_EMBEDDED_PYTHON_TEST? :)
Contributor
There was a problem hiding this comment.
while working on wheels with the apple security settings etc, I am glad that I/we didn't come across this!
nrnhines
approved these changes
Sep 15, 2022
nrnhines
left a comment
There was a problem hiding this comment.
Glad this is becoming available. I've been limited to using nrniv with the address sanitizer on my Apple M1.
alexsavulescu
approved these changes
Sep 15, 2022
olupton
added a commit
that referenced
this pull request
Feb 23, 2023
olupton
added a commit
that referenced
this pull request
Feb 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DYLD_INSERT_LIBRARIESinstead ofLD_PRELOADon macOS.