This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Update nmodl submodule: fixes for WATCH statements on GPU#598
Merged
Conversation
Merged
2 tasks
Collaborator
|
Logfiles from GitLab pipeline #11465 (:white_check_mark:) have been uploaded here! Status and direct links:
|
Contributor
|
GitLab integration seems a bit confused. The pipeline was duplicated, I killed one but https://bbpgitlab.epfl.ch/hpc/coreneuron/-/pipelines/11640 is still running -- not sure if the status here will go green or not 🤷 |
Collaborator
|
Logfiles from GitLab pipeline #11655 (:white_check_mark:) have been uploaded here! Status and direct links:
|
iomaganaris
approved these changes
Jul 23, 2021
Collaborator
|
Logfiles from GitLab pipeline #11689 (:no_entry:) have been uploaded here! Status and direct links:
|
Collaborator
Author
|
The last failure is because I didn't wait for one more CI just because of submodule update in NMODL. It was already validated. |
pramodk
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See BlueBrain/nmodl/pull/710 and BlueBrain/nmodl/issues/679
Todos:
How to test this?
Run testwatch.hoc test from testcorenrn repository
Test System
Use certain branches for the SimulationStack CI
CI_BRANCHES:NEURON_BRANCH=pramodk/watch-codegen-fixes,NMODL_BRANCH=pramodk/watch-codegen-fixes