This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Use of DELETE_ON_ERROR for generating mod files#423
Merged
Conversation
If mod2c fail, the file is generated but empty, because of that they are not generated again and it fails later in a complicated way
pramodk
approved these changes
Nov 12, 2020
| $(VERBOSE).SILENT: | ||
|
|
||
| # delete cpp files if mod2c error, otherwise they are not generated again | ||
| .DELETE_ON_ERROR: |
Collaborator
There was a problem hiding this comment.
.DELETE_ON_ERROR
If .DELETE_ON_ERROR is mentioned as a target anywhere in the makefile, then make will delete the target of a rule if it has changed and its recipe exits with a nonzero exit status, just as it does when it receives a signal.
Never used this before! ⭐ Does this work as expected?
Member
Author
There was a problem hiding this comment.
Yes ;) Works like a charm.
Member
Author
|
Please retest |
Collaborator
|
Ignoring Travis as it's almost dead. |
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
…#423) - If mod2c fail, the file is generated but empty, because of that they are not generated again and it fails later in a complicated way. CoreNEURON Repo SHA: BlueBrain/CoreNeuron@5322b1e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If mod2c fail, the file is generated but empty, because of that they are
not generated again and it fails later in a complicated way