This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Clean code for #250#421
Merged
Merged
Conversation
pramodk
reviewed
Nov 12, 2020
pramodk
left a comment
Collaborator
There was a problem hiding this comment.
lgtm - few minor comments.
nrn_assert is compiled too when in release mode.
pramodk
suggested changes
Nov 13, 2020
Member
Author
|
Please retest |
1 similar comment
Member
Author
|
Please retest |
Member
Author
|
Please retest |
Member
Author
|
Please retest |
alexsavulescu
approved these changes
Nov 18, 2020
pramodk
approved these changes
Nov 18, 2020
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
* Replace assert(!busy) with nrn_assert
nrn_assert is compiled too when in release mode.
* Using using instead of typedef
CoreNEURON Repo SHA: BlueBrain/CoreNeuron@08c2aeb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NEURON_BRANCH=master