This repository was archived by the owner on Mar 20, 2023. It is now read-only.
CORENRN_ENABLE_LEGACY_UNITS default OFF#408
Merged
Merged
Conversation
Consistency of units selection for NEURON and CoreNEURON checked Modern units comes from copy of nrnunits-modern.h eion.cpp nrn_nernst and nrn_ghk computes according to the units selection.
alkino
reviewed
Oct 27, 2020
alkino
reviewed
Oct 27, 2020
Consistency of units selection for NEURON and CoreNEURON checked Modern units comes from copy of nrnunits-modern.h eion.cpp nrn_nernst and nrn_ghk computes according to the units selection.
- use set_property with APPEND so that previous flags
are not overriden
f922d63 to
1a1dc81
Compare
pramodk
reviewed
Nov 4, 2020
| endif() | ||
|
|
||
| if(CORENRN_ENABLE_LEGACY_UNITS) | ||
| set(CORENRN_UseLegacyUnits 1) |
Collaborator
There was a problem hiding this comment.
I am changing CORENRN_UseLegacyUnits to CORENRN_USE_LEGACY_UNITS for naming consistency (i.e. not mixing _ and CamelCase.
Collaborator
Because of this I will go ahead with the merge of this PR. We will sychronise branches later for CI. |
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
* CORENRN_ENABLE_LEGACY_UNITS default OFF
- Consistency of units selection for NEURON and CoreNEURON checked
- Modern units comes from copy of nrnunits-modern.h
eion.cpp nrn_nernst and nrn_ghk computes according to the units selection.
* Changed CORENRN_LegacyFR to CORENRN_ENABLE_LEGACY_UNITS
* inlined chk_nrnunit_consist
* mod2c_core built in ${CMAKE_BINARY_DIR}/bin
* update mod2c
* Update ring data to version 1.3
* set MOD2C_ENABLE_LEGACY_UNITS from CORENRN_ENABLE_LEGACY_UNITS
* Fix compilation issue for GPU build
- use set_property with APPEND so that previous flags are not overridden
CoreNEURON Repo SHA: BlueBrain/CoreNeuron@f2120d3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consistency of units selection for NEURON and CoreNEURON checked
Modern units comes from copy of nrnunits-modern.h
eion.cpp nrn_nernst and nrn_ghk computes according to the units selection.
Partially responds to #405 and neuronsimulator/nrn#521
Interacts with neuronsimulator/nrn#793 and BlueBrain/mod2c#53