Update May 15, 2018 fork activation time as per spec draft#987
Merged
gandrewstone merged 2 commits intoBitcoinUnlimited:devfrom Mar 7, 2018
Merged
Update May 15, 2018 fork activation time as per spec draft#987gandrewstone merged 2 commits intoBitcoinUnlimited:devfrom
gandrewstone merged 2 commits intoBitcoinUnlimited:devfrom
Conversation
According to the draft specification for the upcoming May 15, 2018 Bitcoin Cash HF (bitcoincashorg/spec#53) the activation time is 1526400000, i.e. Tue May 15 18:00:00 CEST 2018
ptschip
approved these changes
Mar 2, 2018
Collaborator
Author
|
travis failure is due to the fact that Since |
6305659 to
4755db6
Compare
Collaborator
Author
|
Using I was able to reproduce the error ( so it seems that for some reason the ctor order is different when using |
Before the default value for mining.forkMay2018Time tweak was
Tue 15 May 2018 12:00:00 UTC. As per spec the actual value to be used
is Tue 15 May 2018 18:00:00 UTC.
While at is use the consensus params interface rather than stating the
epoch directly in the file.
Unfortunately we could not use `CChainParams &Params(const std::string &chain)`
to access to the consensus params definition to define miningForkTime tweak
due to ctor global ordering.
In fact such order is influenced by compiler version, distro and probably linker
version; so for example:
const CChainParams &chainparams = Params(CBaseChainParams::MAIN);
works w/o issue, i.e. test_bitcoin won't segfault during `make check`,
if the build process is carried over on an Ubuntu 16.04. Same code leads
to a segfault on Ubuntu 14.04 and this is why travis was failing (cause
travis use Ubuntu 14.04)
4755db6 to
1a2b795
Compare
dgenr8
reviewed
Mar 7, 2018
| CTweak<uint64_t> miningForkTime("mining.forkMay2018Time", | ||
| "Time in seconds since the epoch to initiate a hard fork scheduled on 15th May 2018.", | ||
| 1526386800); // Tue 15 May 2018 12:20:00 UTC FIXME: use the correct timestamp once the spec will be ready | ||
| 1526400000); // Tue 15 May 2018 18:00:00 UTC |
Collaborator
There was a problem hiding this comment.
The correct human-readable time is Tue 15 May 2018 16:00:00 UTC
marlengit
pushed a commit
to marlengit/BitcoinUnlimited
that referenced
this pull request
Sep 25, 2018
…limited#987) * Add May 15, 2018 HF activation time to consensus params According to the draft specification for the upcoming May 15, 2018 Bitcoin Cash HF (bitcoincashorg/spec#53) the activation time is 1526400000, i.e. Tue May 15 18:00:00 CEST 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See bitcoincashorg/spec#53 for more details.