Modified returning NaN to NULL#225
Merged
GumpacG merged 2 commits intointeg-fix-nan-bugfrom Feb 15, 2023
Merged
Conversation
Yury-Fridlyand
approved these changes
Feb 13, 2023
Codecov Report
@@ Coverage Diff @@
## integ-fix-nan-bug #225 +/- ##
====================================================
Coverage 98.36% 98.36%
- Complexity 3636 3642 +6
====================================================
Files 343 343
Lines 8990 8995 +5
Branches 585 585
====================================================
+ Hits 8843 8848 +5
Misses 142 142
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
forestmvey
approved these changes
Feb 14, 2023
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
fb9ff8c to
ccdf1c6
Compare
Yury-Fridlyand
approved these changes
Feb 14, 2023
...src/test/java/org/opensearch/sql/expression/operator/arthmetic/MathematicalFunctionTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
GabeFernandez310
approved these changes
Feb 14, 2023
GabeFernandez310
pushed a commit
that referenced
this pull request
Feb 15, 2023
Signed-off-by: Guian Gumpac <guian.gumpac@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guian Gumpac guian.gumpac@improving.com
Description
Modified
ln,log,log10, andlog2functions to returnnullwhen the Math functions returnNaN.Issues Resolved
opensearch-project#1280
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.