Add position() string function to PPL#184
Merged
margarit-h merged 4 commits intointeg-add-position-function-to-pplfrom Dec 7, 2022
Merged
Add position() string function to PPL#184margarit-h merged 4 commits intointeg-add-position-function-to-pplfrom
margarit-h merged 4 commits intointeg-add-position-function-to-pplfrom
Conversation
Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com>
Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com>
Codecov Report
@@ Coverage Diff @@
## integ-add-position-function-to-ppl #184 +/- ##
=====================================================================
Coverage 98.31% 98.31%
- Complexity 3485 3486 +1
=====================================================================
Files 348 348
Lines 8707 8711 +4
Branches 555 555
=====================================================================
+ Hits 8560 8564 +4
Misses 142 142
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
acarbonetto
reviewed
Dec 6, 2022
docs/user/ppl/functions/string.rst
Outdated
|
|
||
| Argument type: STRING, STRING | ||
|
|
||
| Return type INTEGER: |
There was a problem hiding this comment.
Suggested change
| Return type INTEGER: | |
| Return type: INTEGER |
acarbonetto
approved these changes
Dec 6, 2022
MitchellGale
approved these changes
Dec 6, 2022
forestmvey
reviewed
Dec 6, 2022
| assertEquals(2, result.getInt("total")); | ||
| verifyDataRows(result, rows("eight"), rows("eleven")); | ||
| } | ||
| } No newline at end of file |
MaxKsyunz
approved these changes
Dec 6, 2022
| assertEquals(2, result.getInt("total")); | ||
| verifyDataRows(result, rows("eight"), rows("eleven")); | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
It really would would like a new line here.
Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com>
GabeFernandez310
approved these changes
Dec 6, 2022
forestmvey
approved these changes
Dec 6, 2022
Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com>
GumpacG
approved these changes
Dec 7, 2022
Yury-Fridlyand
pushed a commit
that referenced
this pull request
Dec 8, 2022
* Add position() string function to PPL (#184) Signed-off-by: Margarit Hakobyan <margarith@bitquilltech.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Margarit Hakobyan margarith@bitquilltech.com
Description
Usage: The syntax POSITION(substr IN str) returns the position of the first occurrence of substring substr in string str. Returns 0 if substr is not in str. Returns NULL if any argument is NULL.
Argument type: STRING, STRING
Return type INTEGER:
(STRING IN STRING) -> INTEGER
Example::
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.