fix(bonjour): suppress ciao IPv4 address-change assertion crash#415
Open
BingqingLyu wants to merge 1 commit intomainfrom
Open
fix(bonjour): suppress ciao IPv4 address-change assertion crash#415BingqingLyu wants to merge 1 commit intomainfrom
BingqingLyu wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@homebridge/ciaothrows an IPv4 transition assertion (Reached illegal state! IPv4 address changed...).ignoreCiaoCancellationRejection()to also suppress ciao IPv4 assertion variants and added focused unit tests.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
Security Impact (required)
No)No)No)No)No)Yes, explain risk + mitigation:Repro + Verification
Environment
Steps
Expected
Actual
Evidence
Crash trace observed before fix:
Validation run:
pnpm vitest run src/infra/bonjour-ciao.test.ts src/infra/bonjour.test.ts src/infra/unhandled-rejections.test.ts # 3 files, 43 tests passedNote: repository-wide
pnpm checkcurrently fails on upstream formatting insrc/cli/daemon-cli/lifecycle.test.ts(unrelated to this PR).Human Verification (required)
What you personally verified (not just CI), and how:
Review Conversations
Compatibility / Migration
Yes)No)No)Failure Recovery (if this breaks)
src/infra/bonjour-ciao.tssrc/infra/bonjour-ciao.test.tsRisks and Mitigations