fix(bonjour): suppress ciao IPv4 address-change assertion crash#27359
fix(bonjour): suppress ciao IPv4 address-change assertion crash#27359stone-jin wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Greptile SummaryExtended Confidence Score: 5/5
Last reviewed commit: 1c3706a |
|
This pull request has been automatically marked as stale due to inactivity. |
|
This pull request has been automatically marked as stale due to inactivity. |
|
Closing due to inactivity. |
Summary
@homebridge/ciaofiresassert.fail()insideMDNSServer.handleUpdatedNetworkInterfaceswhen a network interface's IPv4 address transitions between defined↔undefined (WiFi drop, VPN toggle, sleep/wake).process.exit(1), crashing the gateway.ignoreCiaoCancellationRejectioninsrc/infra/bonjour-ciao.tsto also match ciao's IPv4 address-change assertions, logging them as non-fatal warnings instead of letting them crash the process.@homebridge/ciaodependency itself or other unhandled rejection logic.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
@homebridge/ciaoupstream bug inMDNSServer.handleUpdatedNetworkInterfacesUser-visible / Behavior Changes
Gateway no longer crashes when network interfaces change (WiFi disconnect/reconnect, VPN toggle, sleep/wake). A warning is logged instead.
Security Impact (required)
Repro + Verification
Environment
Steps
Expected
Actual (before fix)
AssertionError [ERR_ASSERTION]: Reached illegal state! IPV4 address change from defined to undefined!Evidence
Error trace before fix:
New tests added in
src/infra/bonjour-ciao.test.tscovering both assertion variants and unrelated error passthrough.Human Verification (required)
Compatibility / Migration
Failure Recovery (if this breaks)
src/infra/bonjour-ciao.tssrc/infra/bonjour-ciao.tsRisks and Mitigations
logWarn), and the bonjour watchdog (60s interval) will attempt re-advertisement if the service falls out ofannouncedstate