Move outcome handling to backend#18
Merged
BeyondEvil merged 2 commits intocombined-fe-and-befrom Aug 9, 2022
Merged
Conversation
aa3759b to
35e2edb
Compare
drRedflint
reviewed
Aug 8, 2022
src/pytest_html/scripts/main.js
Outdated
| const numberOfTests = renderSet.filter(({outcome}) => | ||
| ["Passed", "Failed", "XPassed", "XFailed"].includes(outcome) | ||
| ).length | ||
| if (runningState === "Finished") { |
There was a problem hiding this comment.
how about creating a isDone fn in datamanager?
That way we wont have a need for comparing strings here.
drRedflint
reviewed
Aug 8, 2022
| const allTests = manager.allTests | ||
| const collectedItems = manager.collectedItems | ||
| const runningState = manager.runningState | ||
|
|
There was a problem hiding this comment.
this could be written cleaner using a destruct:
const { filteredTests, allTests, collectedItems, runningState } = manager
drRedflint
reviewed
Aug 8, 2022
src/pytest_html/scripts/main.js
Outdated
|
|
||
| const renderContent = (tests) => { | ||
| const renderSet = tests.filter(({ when }) => when === 'call') | ||
| const renderSet = tests.filter(({ when, outcome }) => when === 'call' || outcome === "Error" ) |
There was a problem hiding this comment.
out of scope for this pr, but I would like to create constants for outcome and when, so we do this:
outcome === ERROR instead of outcome === 'Error'
drRedflint
approved these changes
Aug 8, 2022
drRedflint
left a comment
There was a problem hiding this comment.
Very nice! Some minor comments, but those could easily be dealt with in another PR to maintain scope.
drRedflint
approved these changes
Aug 9, 2022
BeyondEvil
added a commit
that referenced
this pull request
Mar 5, 2023
* fix main.js conflicts * fix js test * fix resource (main.js) test * revert change to report extra * filters style * css and dom brush up * Buildable app * always store data in html * Always store data blob in file * json dump test data * read data from dom element * manually initialize state * minimalistic dataset * simplify included files * Handle report extras * Handle python report hooks * imgviewer * present name in image viewer and open img on click * setup linter for project * conform to styles * show video in imageviewer (#14) * show video in imageviewer * Chore: Pluralize extra (#15) * Add extras.HTML * Move outcome handling to backend (#18) * Move outcome handling to backend * Pass in text version of longrepr if present * make collapse/expand all functional (#20) * make collapse/expand all functional * only create links for text, url and json (#22) * make filter search case insensitive (#21) * make filter search case insensitive * use sessionStorage to prevent preferences to be reapplied on new reports * avoid multiple event bindings + fix filter bug * Collapse individual row Co-authored-by: Jim Brännlund <jim.brannlund@gmail.com> * add no log output captured string * Query params (#25) * Add query params * adjust tests (#26) * Duration format (#27) * adjust tests * build format handler * remove dependency --------- Co-authored-by: Jim Brännlund <jimbrannlund@fastmail.com> * Beyondevil/cleanup (#28) * chore: Cleanup branch before merge * chore: Fix duration and CI * Fix pre-commit issues --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Viktor Gustafsson <vikt.gust@gmail.com>
BeyondEvil
added a commit
that referenced
this pull request
Apr 3, 2023
* fix main.js conflicts * fix js test * fix resource (main.js) test * revert change to report extra * filters style * css and dom brush up * Buildable app * always store data in html * Always store data blob in file * json dump test data * read data from dom element * manually initialize state * minimalistic dataset * simplify included files * Handle report extras * Handle python report hooks * imgviewer * present name in image viewer and open img on click * setup linter for project * conform to styles * show video in imageviewer (#14) * show video in imageviewer * Chore: Pluralize extra (#15) * Add extras.HTML * Move outcome handling to backend (#18) * Move outcome handling to backend * Pass in text version of longrepr if present * make collapse/expand all functional (#20) * make collapse/expand all functional * only create links for text, url and json (#22) * make filter search case insensitive (#21) * make filter search case insensitive * use sessionStorage to prevent preferences to be reapplied on new reports * avoid multiple event bindings + fix filter bug * Collapse individual row Co-authored-by: Jim Brännlund <jim.brannlund@gmail.com> * add no log output captured string * Query params (#25) * Add query params * adjust tests (#26) * Duration format (#27) * adjust tests * build format handler * remove dependency --------- Co-authored-by: Jim Brännlund <jimbrannlund@fastmail.com> * Beyondevil/cleanup (#28) * chore: Cleanup branch before merge * chore: Fix duration and CI * Fix pre-commit issues --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Viktor Gustafsson <vikt.gust@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.