Feat 168 feature map featuremap#71
Feat 168 feature map featuremap#71tshuck-beyond merged 10 commits intofeat-167-add-option-to-use-simplecov-datafrom
Conversation
a072e8f to
686be3e
Compare
59db050 to
af6f414
Compare
hstrowd
left a comment
There was a problem hiding this comment.
This is great. Should we add a step to CI to run bundle exec featuremap validate to demonstrate some of the CI setup we expect/recommend users to employ?
.feature_map/config.yml
Outdated
| url: https://github.com/Beyond-Finance/feature_map | ||
| # Supports link generation in message construction, e.g., release announcements | ||
| documentation_site_url: example.github.io/repo | ||
| documentation_site_url: https://beyond-finance.github.io/feature_map/ |
There was a problem hiding this comment.
This seems a bit dangerous/problematic in this case because the library assumes this is a FeatureMap docs site (source) but in this case that is not the case. This URL is the library user documentation. I would favor using fake URL that more clearly demonstrates the purpose of this URL (e.g. something like https://example.com/feature/map/docs/site/).
There was a problem hiding this comment.
Oh yup. I confused myself here -- great call.
There was a problem hiding this comment.
Do you think that it would be weird to link here? https://beyond-finance.github.io/feature_map/example-docs-site.html
a4ef711 to
00e0933
Compare
5a1e9c3 to
c2f0eb6
Compare
859ea8c
into
feat-167-add-option-to-use-simplecov-data
* Allow test coverage data to be derived from simplecov reports * Use simplecov and POC feature mapping within library to demonstrate simplecov test coverage * Add notes about simplecov commands to test coverage usage * Add updated docs based on updated config * Feat 168 feature map featuremap (#71) * Use slightly more realistic teams * Add basic feature definitions * Apply initial assignments * Update feature map spec to account for new feature mapping * Use real test coverage data for local development * Remove unused sample config * Update references to sample config * Commit sample data to make CI a bit easier * Add feature map assignment validation * Clarify docs site link in config
Based on work from #68. Adds some basic feature mapping + fictional team ownership to feature map such that it can generate its own data for local development.