Group TV into single folder#18
Merged
Betanu701 merged 4 commits intofeature-utilize-dvd-label-batch-processingfrom Oct 19, 2025
Merged
Group TV into single folder#18Betanu701 merged 4 commits intofeature-utilize-dvd-label-batch-processingfrom
Betanu701 merged 4 commits intofeature-utilize-dvd-label-batch-processingfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an opt-in feature to organize TV series discs under parent series folders, improving library structure for multi-disc collections. The changes include a new configuration option (GROUP_TV_DISCS_UNDER_SERIES), database migration, updated folder creation logic, and comprehensive documentation explaining both disc label naming and series grouping features.
Key Changes:
- Added
GROUP_TV_DISCS_UNDER_SERIESconfiguration option that works independently or with existingUSE_DISC_LABEL_FOR_TVfeature - Implemented folder grouping logic in ripper to create hierarchical structures like
/tv/Breaking Bad (2008)/Breaking_Bad_S1D1/ - Expanded documentation with detailed examples covering all feature combinations, troubleshooting guidance, and best practices
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/unittest/test_group_tv_discs.py | Comprehensive unit tests for parent folder generation and integration scenarios with both features |
| setup/arm.yaml | Added configuration option with detailed comments explaining the new grouping feature |
| arm_wiki/Using-Disc-Label-for-TV-Series.md | Significantly expanded documentation covering feature combinations, examples, troubleshooting, and technical details |
| arm/ui/comments.json | Added UI tooltip for the new configuration option |
| arm/ripper/utils.py | New utility function to generate standardized parent folder names for TV series |
| arm/ripper/arm_ripper.py | Updated path construction logic to include parent folder when grouping is enabled |
| arm/models/config.py | Added database column for new configuration option |
| arm/migrations/versions/b2c3d4e5f6g7_config_add_group_tv_discs_under_series.py | Database migration to add the new configuration column |
| arm/migrations/versions/version | Updated migration version reference |
| CHANGELOG.md | Documented the new feature with usage details |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Betanu701 <5798012+Betanu701@users.noreply.github.com>
…delines Fix code style and linting issues for feature-utilize-dvd-label-batch-processing
ba8d7af
into
feature-utilize-dvd-label-batch-processing
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new opt-in feature for organizing TV series discs under a parent series folder, alongside comprehensive documentation updates and supporting code changes. The main goal is to improve folder structure consistency for multi-disc TV series, making libraries more organized and compatible with media servers. The changes include a new configuration option (
GROUP_TV_DISCS_UNDER_SERIES), database migration, logic updates for folder creation, and extensive documentation for both users and developers.New Feature: TV Series Folder Grouping
GROUP_TV_DISCS_UNDER_SERIESconfiguration option that, when enabled, groups all discs of a TV series under a parent folder named after the series (with year), with each disc as a subfolder. This works independently or in combination with the existingUSE_DISC_LABEL_FOR_TVfeature. [1] [2]Database and Model Updates
GROUP_TV_DISCS_UNDER_SERIESboolean column to theconfigtable and updated the model inconfig.pyaccordingly. [1] [2] [3]Folder Structure Logic
arm_ripper.pyto construct output paths based on the new configuration, ensuring discs are grouped under the correct parent folder when the feature is enabled. [1] [2]get_tv_series_parent_folderto standardize parent folder naming for grouped TV series discs.Documentation Enhancements
These changes together make TV series management more predictable and user-friendly, especially for users with large, multi-disc collections.