Skip to content

Fix code style and linting issues for feature-utilize-dvd-label-batch-processing#20

Merged
Betanu701 merged 2 commits intofeature/move-tv-to-single-folderfrom
copilot/check-contributions-guidelines
Oct 19, 2025
Merged

Fix code style and linting issues for feature-utilize-dvd-label-batch-processing#20
Betanu701 merged 2 commits intofeature/move-tv-to-single-folderfrom
copilot/check-contributions-guidelines

Conversation

Copy link
Copy Markdown

Copilot AI commented Oct 19, 2025

This PR addresses code quality issues found in the feature-utilize-dvd-label-batch-processing changes to ensure compliance with the repository's contribution guidelines and coding standards.

Changes Made

Test Files

Fixed linting violations in the new unit test files:

test/unittest/test_disc_label_tv.py:

  • Removed trailing whitespace from 34 blank lines (W293)

test/unittest/test_group_tv_discs.py:

  • Removed trailing whitespace from 30 blank lines (W293)
  • Removed unused MagicMock import (F401)
  • Fixed import statement order to match project conventions (E402)
  • Updated to use consistent sys.path.insert(0, '/opt/arm') pattern like other test files

Migration Files

Verified that both migration files follow proper alembic conventions:

  • a1b2c3d4e5f6_config_add_use_disc_label_for_tv.py
  • b2c3d4e5f6g7_config_add_group_tv_discs_under_series.py

Validation

All files now pass:

  • ✅ flake8 linting with --max-line-length=120 and --max-complexity=15
  • ✅ Python syntax validation
  • ✅ PEP8 compliance
  • ✅ Project-specific code style requirements

Testing

The changes are purely cosmetic (whitespace and import cleanup) and do not modify any test logic or functionality. All test methods, assertions, and test coverage remain identical.

Contribution Guidelines Compliance

This PR ensures the feature code adheres to:

  • Repository's .pylintrc configuration
  • Project's flake8 standards (as defined in .github/workflows/main.yml)
  • Existing code patterns and conventions used throughout the test suite
  • Proper migration file structure per alembic standards

No functional changes were made - this is strictly a code quality improvement to prepare the feature for merge.

Original prompt

For the Pull Request into feature-utilize-dvd-label-batch-processing, go through the changed files and make sure they conform to the contributions guidlines and rules from the repo


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: Betanu701 <5798012+Betanu701@users.noreply.github.com>
Copilot AI changed the title [WIP] Review changed files for contributions guidelines compliance Fix code style and linting issues for feature-utilize-dvd-label-batch-processing Oct 19, 2025
Copilot AI requested a review from Betanu701 October 19, 2025 20:34
@Betanu701 Betanu701 marked this pull request as ready for review October 19, 2025 21:22
@Betanu701 Betanu701 merged commit c04a188 into feature/move-tv-to-single-folder Oct 19, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants