Fix code style and linting issues for feature-utilize-dvd-label-batch-processing#20
Merged
Betanu701 merged 2 commits intofeature/move-tv-to-single-folderfrom Oct 19, 2025
Conversation
Co-authored-by: Betanu701 <5798012+Betanu701@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Review changed files for contributions guidelines compliance
Fix code style and linting issues for feature-utilize-dvd-label-batch-processing
Oct 19, 2025
Betanu701
approved these changes
Oct 19, 2025
Betanu701
approved these changes
Oct 19, 2025
c04a188
into
feature/move-tv-to-single-folder
0 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses code quality issues found in the feature-utilize-dvd-label-batch-processing changes to ensure compliance with the repository's contribution guidelines and coding standards.
Changes Made
Test Files
Fixed linting violations in the new unit test files:
test/unittest/test_disc_label_tv.py:
test/unittest/test_group_tv_discs.py:
MagicMockimport (F401)sys.path.insert(0, '/opt/arm')pattern like other test filesMigration Files
Verified that both migration files follow proper alembic conventions:
a1b2c3d4e5f6_config_add_use_disc_label_for_tv.py✅b2c3d4e5f6g7_config_add_group_tv_discs_under_series.py✅Validation
All files now pass:
--max-line-length=120and--max-complexity=15Testing
The changes are purely cosmetic (whitespace and import cleanup) and do not modify any test logic or functionality. All test methods, assertions, and test coverage remain identical.
Contribution Guidelines Compliance
This PR ensures the feature code adheres to:
.pylintrcconfiguration.github/workflows/main.yml)No functional changes were made - this is strictly a code quality improvement to prepare the feature for merge.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.