Disk Label utilization#16
Merged
Betanu701 merged 5 commits intofeature-utilize-dvd-label-batch-processingfrom Oct 19, 2025
Merged
Disk Label utilization#16Betanu701 merged 5 commits intofeature-utilize-dvd-label-batch-processingfrom
Betanu701 merged 5 commits intofeature-utilize-dvd-label-batch-processingfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
Introduces a new opt-in feature for deterministic TV series folder naming based on disc labels, providing predictable folder structures by parsing season/disc identifiers from volume labels and generating normalized folder names like "Breaking_Bad_S1D1" instead of "Breaking Bad (2008)".
- Adds
USE_DISC_LABEL_FOR_TVconfiguration option with database migration support - Implements intelligent disc label parsing supporting 15+ common label formats with fallback to standard naming
- Includes comprehensive test coverage, detailed documentation, and UI support for the new feature
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/unittest/test_disc_label_tv.py | Complete unit test suite covering parsing, normalization, and integration scenarios |
| setup/arm.yaml | Configuration option with detailed comments explaining the feature behavior |
| arm_wiki/Using-Disc-Label-for-TV-Series.md | Comprehensive documentation with examples, troubleshooting, and best practices |
| arm/ui/comments.json | UI comment describing the configuration option for end users |
| arm/ripper/utils.py | Core implementation with parsing, normalization, and folder name generation functions |
| arm/ripper/arm_ripper.py | Integration of TV folder naming logic into the main ripping workflow |
| arm/models/config.py | Database model update to support the new configuration column |
| arm/migrations/versions/* | Database migration script and version update |
| CHANGELOG.md | Feature documentation in project changelog |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…tion Co-authored-by: Betanu701 <5798012+Betanu701@users.noreply.github.com>
…elines Fix flake8 linting issues to comply with contribution guidelines
6fa7771
into
feature-utilize-dvd-label-batch-processing
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new opt-in feature for deterministic TV series folder naming based on disc labels, making TV series organization more predictable and automation-friendly. The implementation includes configuration, migration, model, and logic changes, along with documentation and UI comments to support the feature. The system falls back to the previous naming scheme if parsing fails or the feature is disabled, ensuring backward compatibility.
New Feature: Disc Label-Based TV Series Folder Naming
Configuration & Database Support
USE_DISC_LABEL_FOR_TVconfiguration option toarm.yaml, enabling users to opt into disc label-based naming for TV series output folders.configtable and model. [1] [2] [3]TV Series Folder Naming Logic
arm_ripper.pyandutils.pyto parse disc labels for season/disc identifiers and generate normalized, deterministic folder names for TV series (e.g.,Breaking_Bad_S1D1). Falls back to standard naming if parsing fails or the feature is disabled. [1] [2] [3] [4]Documentation & UI Support
arm_wiki/Using-Disc-Label-for-TV-Series.md, covering configuration, supported patterns, examples, troubleshooting, and best practices for the new feature.comments.jsonto describe the new configuration option and its behavior for end users.Changelog
Add either feature or bugfix to the title inline with the software version increment