Skip to content

Fix flake8 linting issues to comply with contribution guidelines#17

Merged
Betanu701 merged 2 commits intofeature/utilize-disk-label-tv-seriesfrom
copilot/check-contribution-guidelines
Oct 19, 2025
Merged

Fix flake8 linting issues to comply with contribution guidelines#17
Betanu701 merged 2 commits intofeature/utilize-disk-label-tv-seriesfrom
copilot/check-contribution-guidelines

Conversation

Copy link
Copy Markdown

Copilot AI commented Oct 19, 2025

Overview

This PR fixes code style issues to ensure full compliance with the repository's contribution guidelines and coding standards as defined in .pylintrc and CONTRIBUTING.md.

Issues Fixed

The changes in the feature-utilize-dvd-label-batch-processing branch introduced several flake8 linting violations that needed to be addressed before merge:

W293: Blank line contains whitespace

  • arm/ripper/utils.py: 18 instances of trailing whitespace in blank lines within docstrings and function bodies
  • test/unittest/test_disc_label_tv.py: 40 instances of trailing whitespace throughout the test file

E128: Continuation line under-indented for visual indent

  • arm/ripper/utils.py: 2 instances of improperly indented continuation lines in multi-line logging statements (lines 320 and 325)

Changes Made

All fixes are non-functional changes that only affect code formatting:

  1. Removed trailing whitespace from blank lines to comply with PEP 8
  2. Corrected indentation of continuation lines in multi-line f-string logging statements to align properly with opening delimiter

Before:

logging.info(f"Using disc label-based folder name: '{folder_name}' "
            f"(from series '{series_name}' and label '{job.label}')")

After:

logging.info(f"Using disc label-based folder name: '{folder_name}' "
             f"(from series '{series_name}' and label '{job.label}')")

Verification

  • ✅ All files pass flake8 . --max-complexity=15 --max-line-length=120 with zero warnings
  • ✅ Code follows .pylintrc standards (max-line-length=120, new-style logging format)
  • ✅ No functional changes to code logic
  • ✅ Automated code review completed with no issues

Related Feature

These fixes apply to the DVD label batch processing feature which:

  • Parses disc labels to extract season/disc identifiers (e.g., S1D1, Season01Disc02)
  • Normalizes series names for filesystem safety
  • Generates TV folder names based on disc labels when USE_DISC_LABEL_FOR_TV is enabled

The feature is fully documented in setup/arm.yaml and includes comprehensive unit tests in test/unittest/test_disc_label_tv.py.

Statistics

  • Files modified: 2
  • Total changes: 116 lines (58 insertions, 58 deletions - whitespace only)
  • Linting issues resolved: 60
  • New issues introduced: 0
Original prompt

For the Pull Request into feature-utilize-dvd-label-batch-processing, go through the changed files and make sure they conform to the contributions guidlines and rules from the repo


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…tion

Co-authored-by: Betanu701 <5798012+Betanu701@users.noreply.github.com>
Copilot AI changed the title [WIP] Review changed files for contribution guideline compliance Fix flake8 linting issues to comply with contribution guidelines Oct 19, 2025
Copilot AI requested a review from Betanu701 October 19, 2025 19:53
@Betanu701 Betanu701 marked this pull request as ready for review October 19, 2025 19:55
@Betanu701 Betanu701 merged commit 94b6fa9 into feature/utilize-disk-label-tv-series Oct 19, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants