Merged
Conversation
Kasuromi
approved these changes
Apr 1, 2023
js6pak
reviewed
Apr 1, 2023
Comment on lines
+10
to
+13
| private bool isApplied; | ||
| private T detour; | ||
| internal T method; | ||
| internal T original; |
Member
There was a problem hiding this comment.
Wrong naming, fields should be private and begin with _ and _original should be exposed with something like
public T Original => _original;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the way hooks are done. Now a hook is created by implementing Hook class. The only things that need to be defined are the hook delegate, hook method and find target method function.
This removes some boilerplate code, and splits hooks across files for more modularity.
No functional changes. Tested on Core Keeper 2021.3.14f